convert FLTBetterPlayerPlugin from Objective C to swift #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicholasNagy
approved these changes
Apr 15, 2025
Owner
NicholasNagy
left a comment
NicholasNagy
left a comment
There was a problem hiding this comment.
I had a small comment about some example code, which is not a big deal tbh.
Great job on the swift rewrite, lots of comments explaining stuff is going to be helpful too. Thanks :)
example/lib/main.dart
Outdated
Comment on lines
127
to
151
|
|
||
| // import 'package:flutter/material.dart'; | ||
|
|
||
| // void main() => runApp(App()); | ||
|
|
||
| // class App extends StatelessWidget { | ||
| // const App({Key? key}) : super(key: key); | ||
|
|
||
| // @override | ||
| // Widget build(BuildContext context) { | ||
| // return Container( | ||
| // color: Colors.black, | ||
| // child: MaterialApp( | ||
| // home: Scaffold( | ||
| // body: Center( | ||
| // child: Text( | ||
| // "Hello World", | ||
| // style: TextStyle(color: Colors.black), | ||
| // ), | ||
| // ), | ||
| // ), | ||
| // ), | ||
| // ); | ||
| // } | ||
| // } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
The main file to look at is "FLTBetterPlayerPlugin.swift".