Skip to content

fixed modsByUid handler ignoring the modQuery #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IDCs wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fixed modsByUid handler ignoring the modQuery #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd55116
fixed modsByUid handler ignoring the modQuery
IDCs Jan 20, 2026
b97c554
Merge branch 'master' into fix/mods-by-uid
IDCs Jan 26, 2026
8475b10
fixing conflict
IDCs Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Nexus.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/Nexus.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/Nexus.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,7 +857,7 @@ class Nexus {
* the second 32bit block identifies the mod) clients should use BigInt to do the math and
* then pass them in as strings
*/
public async modsByUid(query: graphQL.IModQuery, uids: string[]): Promise<Partial<types.IMod>[]> {
public async modsByUid(query: graphQL.IModQuery, uids: string[]): Promise<Partial<types.IMod>[]> {
const res: Partial<types.IMod>[] = [];
for (const chunk of chunkify(uids, param.MAX_BATCH_SIZE)) {
await this.mQuota.wait();
Expand All @@ -867,7 +867,7 @@ class Nexus {
{
uids: { type: '[ID!]', optional: false },
},
{ nodes: chunk }, { uids },
{ nodes: query }, { uids: chunk },
this.args({ path: this.filter({}) }))).nodes);
}

Expand Down