Refactored Views #19400
Draft
Refactored Views #19400
+6,675
−3,687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split ApplicationLayout into smaller components Added proper Redux usage
Corrected exports
Renamed ApplicationLayout to AppLayout
Converted more to functional components, replaced HOC with hooks Fixed tests
# Conflicts: # src/renderer/views/GlobalOverlay.tsx # src/renderer/views/MainOverlay.tsx
Separated AppLayout into ClassicLayout (current) and ModernLayoutt (next) Added button to switch between layouts and the Redux state for it Type fixes for existing code
# Conflicts: # src/renderer.tsx
r1chm8
force-pushed
the
renderer-main-window-refactor
branch
from
d7ef76e to
8a4e377
Compare
# Conflicts: # src/renderer.tsx
Correctly select the Spine entry on profile change
Moved Hooks into a hooks folder Fixed and simplified Icons, there was a rather critical race condition that prevented icon load on Modern since it was too fast Standardized components Simplified AppLayout down to the simplest form possible Added more fine grained context
Split Header, Menu and Spine into subcomponents
r1chm8
force-pushed
the
renderer-main-window-refactor
branch
from
b50b137 to
e68715d
Compare
Aragas
commented
Feb 3, 2026
Comment on lines
35
to
36
|
|
||
| const message = options.message ?? ""; | ||
| const meta = options.meta.extra ?? ""; | ||
| const process = options.meta.process.toUpperCase(); |
Member
Author
There was a problem hiding this comment.
Before merging, check whether it still will be required
r1chm8
force-pushed
the
renderer-main-window-refactor
branch
from
8ed8268 to
6fd3187
Compare
Show store icon on game entry hover
r1chm8
force-pushed
the
renderer-main-window-refactor
branch
from
8234cdb to
6b1b488
Compare
# Conflicts: # src/renderer/views/Dialog.tsx # src/renderer/views/WindowControls.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Views are now functional components*
HOCS are replaced with Hooks
Renamed MainWindow to ApplicationLayout
Split ApplicationLayout into smaller components
*except one class