fix(pl): /proc/mounts octal escapes + Encode compat for Perl 5.8#40
Merged
Neo23x0 merged 1 commit intoNextronSystems:script-robustnessfrom Mar 18, 2026
Merged
Conversation
…Perl 5.8 - /proc/mounts: decode \040 and other octal escapes in mount points so paths with spaces are correctly recognized and excluded - Encode::FB_DEFAULT(): use numeric constant 0x0001 instead of the named function, which was only added in Encode 2.53 (Perl 5.14). The script targets Perl 5.8+, where the function doesn't exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes in the Perl collector, found by Axiom-Loop review (verified round):
/proc/mounts octal escapes — Mount points with spaces are encoded as
\040in /proc/mounts. The simplesplit(/\s+/)broke on these. Now decodes\NNNoctal escapes before use, so network/special filesystem exclusions work on paths like/mnt/backup server.Encode::FB_DEFAULT() compat —
Encode::FB_DEFAULT()was introduced in Encode 2.53 (Perl 5.14), but the script targets Perl 5.8+. Replaced with the numeric constant0x0001which works on all versions.