Skip to content

fix: TOCTOU race in mktemp_portable fallback #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Neo23x0 merged 1 commit into from
Mar 17, 2026
Merged

fix: TOCTOU race in mktemp_portable fallback #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions scripts/thunderstorm-collector.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,9 @@ cleanup_tmp_files() {
for f in "${TMP_FILES_ARR[@]}"; do
[ -n "$f" ] && [ -f "$f" ] && rm -f "$f"
done
# Remove fallback temp directory if it exists (created by mktemp_portable)
local _fallback_dir="${TMPDIR:-/tmp}/thunderstorm.$$"
[ -d "$_fallback_dir" ] && rm -rf "$_fallback_dir"
}

INTERRUPTED=0
Expand Down Expand Up @@ -363,9 +366,14 @@ mktemp_portable() {
echo "$t"
return 0
fi
# Fallback: RANDOM may be empty in non-bash shells
t="${TMPDIR:-/tmp}/thunderstorm.$$.${RANDOM:-0}.$(date +%N 2>/dev/null || echo 0)"
( umask 077 && : > "$t" ) 2>/dev/null || return 1
# Fallback: create a private directory first (mkdir is atomic), then a file inside it.
# This avoids the TOCTOU race of creating a predictable file in a shared /tmp.
local _dir="${TMPDIR:-/tmp}/thunderstorm.$$"
if [ ! -d "$_dir" ]; then
( umask 077 && mkdir "$_dir" ) 2>/dev/null || return 1
fi
t="$_dir/${RANDOM:-0}.$(date +%N 2>/dev/null || echo 0)"
: > "$t" 2>/dev/null || return 1
echo "$t"
}

Expand Down
Loading