[FD-79] image picker 추가 #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 테스트 코드 추가 - 버튼 visibility 조정
soyeonLee126
commented
Jan 30, 2026
Collaborator
Author
There was a problem hiding this comment.
color scheme이름은 일단 아무거나 끼워뒀습니다! 추후 맞춰 변경 예정입니다
Hoseong-Ryu
requested changes
Feb 1, 2026
Collaborator
Hoseong-Ryu
left a comment
Hoseong-Ryu
left a comment
There was a problem hiding this comment.
clearCache를 언제할지 정해야될 것 같기는한데 MVP 나오고 실기기로 테스트해보면서 OOM 직접 터뜨려보면서 정해볼까요..?
수고하셨습니다~!
|
|
||
| private data class PhotoWithClassification( | ||
| val uriString: String, | ||
| val result: com.nexters.fooddiary.domain.model.ClassificationResult? |
Collaborator
There was a problem hiding this comment.
p5. AI 사용하고 저도 자주하는 실수... import 부탁드리겠습니다..!
| lifecycleViewmodelCompose = "2.8.7" | ||
| activityCompose = "1.9.3" | ||
| composeBom = "2025.12.01" | ||
| composeBom = "2024.11.00" |
Collaborator
There was a problem hiding this comment.
p4. 버전을 변경했어야하는 이유가 있었나요?
Comment on lines
+25
to
+27
| val uriString = mediaItem.uri | ||
| val result = classificationRepository.classifyImage(uriString) | ||
| PhotoWithClassification(uriString, result) |
Collaborator
There was a problem hiding this comment.
p2. async await으로 처리하면 비동기 처리를 더 효율적으로 사용할 수 있을 것 같아요
| val result = runCatching { | ||
| classifyImageUseCase(uri.toString()) | ||
| }.getOrNull() | ||
| val idx = index |
Collaborator
There was a problem hiding this comment.
p5. 여기 idx 변수 선언 사용하지 않아도 괜찮을 것 같아요
| import com.nexters.fooddiary.domain.model.ClassificationResult | ||
|
|
||
| data class ClassifiedImageItem( | ||
| val bitmap: Bitmap, |
Collaborator
There was a problem hiding this comment.
p3. Bitmap을 상태로 저장하는 것보다는 URI를 저장하는게 메모리 사용량을 줄일 수 있을 것 같아요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경 내용
체크리스트