Added LoopTimeComponent and VoltageCompensatingMotor to docs #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added docs for voltage compensating motor, although example is little long, not sure how it will display
Added LoopTimeComponent part to TeleOp section of guide
AchintyaAkula
changed the title
AchintyaAkula
changed the title
zachwaffle4
requested changes
Jan 5, 2026
| // or with "ideal" voltage(Volts) and voltage caching time(seconds/Duration) specifications | ||
| val myVoltageCompensatingMotor = VoltageCompensatingMotor(myMotorEx, 500.milliseconds, 12.0) | ||
| val myVoltageCompensatingMotor = VoltageCompensatingMotor(myMotorEx, 0.5, 12.0) | ||
| val myVoltageCompensatingMotor = VoltageCompensatingMotor(myMotorEx, "0.5", 12.0) |
Contributor
There was a problem hiding this comment.
I do not want duration strings in Kotlin examples; Kotlin users have the extension properties available to create actual Duration objects.
zachwaffle4
reviewed
Jan 5, 2026
|
|
||
| // or with "ideal" voltage(Volts) and voltage caching time(seconds) specifications | ||
| VoltageCompensatingMotor myVoltageCompensatingMotor = new VoltageCompensatingMotor(myMotorEx, 0.5, 12.0) | ||
| VoltageCompensatingMotor myVoltageCompensatingMotor = new VoltageCompensatingMotor(myMotorEx, "0.5", 12.0) |
Contributor
There was a problem hiding this comment.
"0.5" is not a valid duration string. "500ms" and "0.5s" would be correct here.
Contributor
Author
There was a problem hiding this comment.
Got it. Just fixed it to have 500ms instead, and removed the kotlin example as mentioned above that uses a string. Please review my changes
Updated examples of VoltageCompensatingMotor initialization to use numeric values instead of strings for voltage caching time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added voltage compensating motor, example is slightly lengthy, not sure how it will display.
Also added Looptime Component to components list