Skip to content

Fix initialization of value in Button and Variable classes #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zachwaffle4 wants to merge 1 commit into from
Closed

Fix initialization of value in Button and Variable classes #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/kotlin/dev/nextftc/bindings/Button.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ class Button(private val valueSupplier: Supplier<Boolean>) : Supplier<Boolean> {
class Named(val name: String?) : Layer
}

private var value: Boolean = valueSupplier.get()
private var value: Boolean = false
private var previousValue = value

/**
Expand Down
4 changes: 2 additions & 2 deletions src/main/kotlin/dev/nextftc/bindings/Variable.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ import java.util.function.Supplier
* @see Range for creating a double variable with number-specific utilities.
*/
open class Variable<T>(private val valueSupplier: Supplier<T>) : Supplier<T> {
private var value: T = valueSupplier.get()
private var value: T? = null

/**
* Gets the cached value of the variable. The cached value is updated when [update] is called.
*/
override fun get(): T = value
override fun get(): T = value ?: error("Variable not updated; call update() first")

/**
* Creates a new [Variable] that maps the value of this variable using the given [mapper] and registers it with
Expand Down