Open
Conversation
Sylvaner
force-pushed
the
NativeNotifications
branch
2 times, most recently
from
59dcb26 to
4663e85
Compare
cyrilphoenix71
requested changes
Jan 24, 2020
Contributor
cyrilphoenix71
left a comment
cyrilphoenix71
left a comment
There was a problem hiding this comment.
Pour la PR notifs :
- Je viens de pousser fix car le gen_assets passe pas
- Si ca marche > faire : Notification.requestPermission() pour avoir demande du navigateur
- donc il manque un truc car j'ai du request a la main ou parce que j'avais ptre deja un jour dis non
- du coup si on dit non on a pu rien et pu aucun retour gui donc on sait pas ce qui se passe
- les notifs sont par dessus tout appli ouverte sur le PC
- l'icone erreur bof lol (mais je peux m'en occuper)
- les notifs ne s'empilent pas donc si tu en 15 d'affilé (restore) elles s'affichent les une apres les autres donc ca prend 10min
je suis pas pour meme si le fond d'une dep en moins ok
|
Je n'ai pas testé, mais se séparer des notifs existantes je suis contre. Ajouter ceci en option éventuellement. |
Sylvaner
force-pushed
the
NativeNotifications
branch
from
4663e85 to
9e03afd
Compare
Contributor
Author
O_o t'as pas testé et t'es contre ? :) |
Sylvaner
force-pushed
the
NativeNotifications
branch
from
9e03afd to
b4bb9e1
Compare
Fix gen_assets
Sylvaner
force-pushed
the
NativeNotifications
branch
from
b4bb9e1 to
b392a45
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Collaborator
|
Je suis pour cette feature, on se débarasse d'une lib en plus. |
ColonelMoutarde
approved these changes
Apr 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposition de notifications natives
On supprime une dépendance et moins de lignes.
Pour tester, faites afficher un message
Ne pas merger sans un accord concret :)