Add Webpack and babel for transpiling source code#48
Open
amoshydra wants to merge 5 commits intoNextBoy:masterfrom
Open
Add Webpack and babel for transpiling source code#48amoshydra wants to merge 5 commits intoNextBoy:masterfrom
amoshydra wants to merge 5 commits intoNextBoy:masterfrom
Conversation
Source files will now be transpiled into es5 compatible code according to the .babelrc configuration
This files are not used at the moment since all of the codes are already copied into index.js previously. The code found inside here are not the most updated version too. Additional mirroring will be required.
All exported class and functions inside index.js are mirrored into their respective module. These modules are then exported like they were before.
Also configure webpack to build code into UMD format
Author
|
中文翻译 添加了webpack构建管道
希望解决:#25,#26,,#35,#42 向后兼容此PR应与现有版本向后兼容,如果开发者根据 README 的方法使用,在更新此版本时不需进行任何更改。 import {container, ImageExtend, QuillWatch} from 'quill-image-extend-module'但是,下面的导入方式将会停止运行。我想开发者也不会使用这方法导入。 import container from from 'quill-image-extend-module/container'
import ImageExtend from 'quill-image-extend-module/ImageExtend'
import QuillWatch from 'quill-image-extend-module/QuillWatch'IE兼容性虽然有这个 PR 开发人员将能够在 IE 上导入此模块,仍会有一个错误阻止IE用户上传图片。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added webpack build pipeline to
Hope to resolve:
Tested with: https://codesandbox.io/s/vq10k6y42y
Backward compatibility
This PR should be backward compatible with the existing version, developer should not be expected to make any changes when updating to this version. if they are using the module according the to README's instruction.
The code below however, will cease to work. I suspect the developers should not import this module using this method anyway.
Note for IE compatibility
Although with this PR. developer will be able to use this module on IE. There is still a bug prevent IE user from uploading image. However, I believe this should be resolved in a separate issue #47