fix: fix model thumbnails #427
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Previously, the thumbnails for the models were generated by kinda "guessing" the rough size based on the size value of the
TransformComponent. But this was mostly incorrect because every model can be different when imported.So now, thanks to the PR #426 we have access to the AABB and bounding spheres of the imported models.
Thanks to that, we can simply position the camera to encapsulate the bounding volume of the model in the thumbnail.
Description
The idea is to treat the model’s bounding sphere as the region that must fully fit inside the camera’s view frustum. By knowing the sphere’s radius, the camera’s field of view (FOV), and the aspect ratio, we can compute the exact distance required for the camera so that the entire model is visible without being clipped or cropped.
In practice:
kThumbDir) so that it looks directly at the model.This method ensures that thumbnails remain visually consistent and correctly framed for any model.