Feat loading empty state #84
Conversation
Summary of ChangesHello @kraayush952-dotcom, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the dashboard's home page by implementing an empty state UI. This ensures that users are presented with a clear and informative message when there is no data to display, preventing blank screens and providing better guidance. The change primarily focuses on the frontend user experience, with a minor backend dependency cleanup. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces an empty state UI for the dashboard and cleans up a duplicate dependency. The new UI logic in HomePage.tsx has a critical flaw where it violates React's Rules of Hooks by placing an early return before a hook call. I've also included a minor suggestion to simplify the conditional logic for the empty state. The dependency change in package.json is a good fix.
| if (!features || features.length === 0) { | ||
| return ( | ||
| <div className="flex items-center justify-center min-h-screen bg-[#1E1E1E] text-gray-400"> | ||
| No data available at the moment | ||
| </div> | ||
| ) | ||
| } |
There was a problem hiding this comment.
This conditional return is placed before the useGSAP hook call on line 45. This violates the Rules of Hooks, which state that hooks must be called at the top level of a component and in the same order on every render. An early return causes hooks to be called conditionally, which can lead to unpredictable bugs. To fix this, please ensure all hook calls (like useGSAP) are executed before any conditional return statements.
| ] | ||
|
|
||
| // ✅ EMPTY STATE UI (Issue #79) | ||
| if (!features || features.length === 0) { |
There was a problem hiding this comment.
The check !features is redundant here. Since features is initialized as an array literal on line 17, it will never be a falsy value like null or undefined. You can simplify the condition for clarity.
| if (!features || features.length === 0) { | |
| if (features.length === 0) { |
3 participants
Fixes #79
This PR adds an empty state UI to the dashboard home page
to improve user experience when no data is available.