-
Notifications
You must be signed in to change notification settings - Fork 44
fix: remove duplicate bcrypt dependency #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: remove duplicate bcrypt dependency #83
Conversation
Summary of ChangesHello @kraayush952-dotcom, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a dependency management issue by eliminating a redundant "bcrypt" entry in the "package.json" file. The primary goal is to streamline the project's dependencies, prevent potential version conflicts that could arise from having two different versions of the same package, and maintain a clean and accurate dependency list. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly removes a duplicate bcrypt dependency, which is a good step towards cleaning up the project's dependencies.
However, I've found a few other issues related to dependency management:
- Some
@types/*packages are incorrectly placed independenciesinstead ofdevDependencies. One of them is also obsolete and should be removed. - The remaining
bcryptversion is invalid and will break the build. - The repository contains both
package-lock.jsonandpnpm-lock.yaml. It is a best practice to standardize on a single package manager (npmorpnpm) and use only its corresponding lock file to ensure consistent dependency resolution across all environments.
I've added specific comments with suggestions to address these points.
| "argon2": "^0.44.0", | ||
| "bcrypt": "^5.1.1", | ||
| "axios": "^1.12.2", | ||
| "bcrypt": "^6.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "@langchain/ollama": "^0.2.4", | ||
| "@types/cookie-parser": "^1.4.9", | ||
| "@types/jsonwebtoken": "^9.0.10", | ||
| "@types/mongoose": "^5.11.97", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @types/mongoose package should be removed. It is listed as a production dependency, but type definitions are only for development. More importantly, mongoose@8+ (you are using ^8.19.1) bundles its own types, so this package is unnecessary. The version you have (^5.11.97) is also for an older, incompatible version of Mongoose.
| "@types/cookie-parser": "^1.4.9", | ||
| "@types/jsonwebtoken": "^9.0.10", | ||
| "@types/mongoose": "^5.11.97", | ||
| "@types/morgan": "^1.9.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #63
This PR removes the duplicate
bcryptdependency fromLocalMind-Backend/package.jsonto prevent version conflicts and keep dependencies clean.Changes
bcryptentry