-
Notifications
You must be signed in to change notification settings - Fork 44
fix #130 #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #130 #132
Conversation
Thanks for creating a PR for your Issue!
|
Summary of ChangesHello @neeru24, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates directory names in README.md from server/client to LocalMind-Backend/LocalMind-Frontend. This is a good change for consistency. However, I've identified a critical issue in the Quick Start instructions where the sequence of commands will fail; I've provided a suggested fix. Additionally, the refactoring seems incomplete, as several other references to the old directory names remain in README.md. Please update these as well for complete consistency.
| cd LocalMind-Backend && npm install | ||
| cd ../LocalMind-Frontend && npm install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cd commands change the current working directory. After these two commands run, the shell will be inside the LocalMind-Frontend directory. This will cause the subsequent command, cd LocalMind-Backend && npm run dev, to fail because it's executed from the wrong location.
To fix this, you can run the installation commands within subshells by wrapping them in parentheses. This executes the commands in the correct subdirectories without changing the working directory of the main shell, ensuring that subsequent commands run from the correct project root.
| cd LocalMind-Backend && npm install | |
| cd ../LocalMind-Frontend && npm install | |
| (cd LocalMind-Backend && npm install) | |
| (cd LocalMind-Frontend && npm install) |
fixes #130
@abhishek-nexgen-dev