Skip to content

Fix UTF-8 fallback when abbreviating names #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DelaneDiamon wants to merge 1 commit into from
Closed

Fix UTF-8 fallback when abbreviating names #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion modules/tags.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,24 @@ end

-- Name abbreviation
local function abbreviateName(text)
return (string.utf8sub or string.sub)(text, 1, 1) .. "."
if not text or text == "" then
return "."
end

if utf8sub then
-- Use Blizzard's UTF-8 safe substring helper when available
local first = utf8sub(text, 1, 1)
if first and first ~= "" then
return first .. "."
end
end

local first = string.match(text, "[%z\1-\127\194-\244][\128-\191]*")
if not first or first == "" then
first = string.sub(text, 1, 1)
end

return first .. "."
end

Tags.abbrevCache = setmetatable({}, {
Expand Down