Add option to keep original tracks (keep_org_tracks)#75
Open
lukeIam wants to merge 1 commit intoNeurrone:mainfrom
Open
Add option to keep original tracks (keep_org_tracks)#75lukeIam wants to merge 1 commit intoNeurrone:mainfrom
lukeIam wants to merge 1 commit intoNeurrone:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even with
match_chapters==Falsethe plugin sometimes manipulates the tracks:Actually exactly then when len(a.tracks) != len(items)
This then leads to a perfectly matching between items and tracks -> track amount and length is basically useless in the matching process (distance 0 instead of an actual high distance).
Therefore I added the new option
keep_org_tracksto be able to disable the track manipulation by this plugin completely.Note: I'm aware of that I then need to handle the matching/filling on my own...
If you want to make it optional it in another way it's also fine for me...