Proof Minimization#890
Merged
omriisack merged 250 commits intoNeuralNetworkVerification:masterfrom Nov 2, 2025
Merged
Conversation
Added removeIf wrapper function
Fixed Identation
Fixed indentation
Fixed indentation
Correct version of file
Fixed formatting
Fixed formatting
Added a test of removeIf() method
Added a test of const operator[]
# Conflicts: # src/configuration/GlobalConfiguration.cpp # src/engine/BoundManager.cpp # src/engine/Engine.cpp # src/engine/Engine.h # src/engine/IEngine.h # src/engine/PiecewiseLinearConstraint.cpp # src/engine/tests/MockEngine.h
guykatzz
approved these changes
Nov 2, 2025
| const bool GlobalConfiguration::ANALYZE_PROOF_DEPENDENCIES = false; | ||
| const bool GlobalConfiguration::MINIMIZE_PROOF_DEPENDENCIES = false; | ||
| const bool GlobalConfiguration::ANALYZE_PROOF_DEPENDENCIES = true; | ||
| const bool GlobalConfiguration::MINIMIZE_PROOF_DEPENDENCIES = true; |
Collaborator
There was a problem hiding this comment.
Just making sure this is as intended. I'm guessing proofs are generally off by default, but if they're on - these should be on?
Contributor
There was a problem hiding this comment.
Exactly. If proof production is off (default), these configurations are meaningless
omriisack
merged commit 52f7407
into
NeuralNetworkVerification:master
1 of 8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce GroundBoundManager module, and the proof minimization algorithm