Maxwell rawio implementation

[samuelgarcia]

@yger @alejoe91
Could you test this ?

[pep8speaks]

Hello @samuelgarcia! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file neo/rawio/maxwellrawio.py:

Line 78:100: E501 line too long (111 > 99 characters)
Line 194:79: W291 trailing whitespace
Line 213:100: E501 line too long (113 > 99 characters)
Line 216:100: E501 line too long (116 > 99 characters)
Line 219:100: E501 line too long (113 > 99 characters)

Comment last updated at 2021-06-18 10:19:38 UTC

[samuelgarcia]

@yger @alejoe91 : can you make feedback on this soon so we could merge this ?

[samuelgarcia]

As soon as files are merge in gin. This is ready to review.

[alejoe91]

@samuelgarcia maybe a possible solution is to add the libcompression.so in the maxwell folder and add the env variable before testing?

[samuelgarcia]

I prefer not include the libcompression.so in the code. We need permission for that.
Maybe we could write a libcompression.so retriever but I don't have time for that at the moment.
I think the error message is enough and is already a big improvement for user compare to previous extractor no ?

[alejoe91]

Yes. I asked maxwell to make it downloadable via wget

[samuelgarcia]

OK we can try a:

• wget in the yml of github actions
• wget in python code (more work)

[samuelgarcia]

@JuliaSprenger : can you have a look to this I patch the download_dataset() and add the update stage.
So distant changes will be updated locally now.
When this will be merge other PR will be OK.

[samuelgarcia]

@alejoe91 : I add a util function auto download this plugin.
test are still failing. I prefer to disable for now.
We will see this later.

[samuelgarcia]

Ready to review.

[samuelgarcia]

@apdavison : If this pass tests, could we merge this soon ?
This PR will unblock other PR and will fix the file caching.
Now any PR take more than 1 hour.

[samuelgarcia]

Ready to review (and merge maybe)