Skip to content

Conversation

@corneyl
Copy link

@corneyl corneyl commented May 10, 2017

Fixes #328: Python 3 compatibility of TdtIO.get_chunks()

@coveralls
Copy link

coveralls commented May 10, 2017

Coverage Status

Coverage increased (+0.007%) to 50.353% when pulling 4347569 on corneyl:master into 4ee20e6 on NeuralEnsemble:master.

@corneyl corneyl changed the title TdtIO: Changed itertools.izip import to make it compatible with python 3 TdtIO: Improved python 3 compatability May 10, 2017
@coveralls
Copy link

coveralls commented May 10, 2017

Coverage Status

Coverage increased (+0.007%) to 50.353% when pulling 1c293b2 on corneyl:master into 4ee20e6 on NeuralEnsemble:master.

@corneyl corneyl changed the title TdtIO: Improved python 3 compatability TdtIO: Improved python 3 compatability and small bug fixes May 11, 2017
@corneyl
Copy link
Author

corneyl commented May 11, 2017

While using TDT files, I came across some more small bugs, so I changed the PR to a more general one.
Let's say it's still work in progress for now, if I encounter more small bugs, I'll push the fixes to this PR.

@apdavison
Copy link
Member

@corneyl please let us know when this is no longer work-in-progress

@samuelgarcia
Copy link
Contributor

PR #385 will be in conflict with this, I guess.

@corneyl
Copy link
Author

corneyl commented Sep 19, 2017

Yes, although the fixes are partially for the same problems.
I'm not using TDT files at the moment, but I can try to look into this PR tomorrow.

@samuelgarcia
Copy link
Contributor

PR #385 have solved this and now Tdt is implemented is rawio.

So this is not compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants