Skip to content

Conversation

@alejoe91
Copy link
Contributor

@alejoe91 alejoe91 commented Jul 9, 2021

In some older files, the lsb field might not be present in settings. In that case, the gain_uV can be computed as:

gain_uV = 3.3 / (1024 * gain) * 1e6

where gain is the amplifier gain, 3.3 is the ADC voltage range, and 1024 (10^10), is the number of bits of the ADC.

@pep8speaks
Copy link

pep8speaks commented Jul 9, 2021

Hello @alejoe91! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-09 15:51:19 UTC

@JuliaSprenger
Copy link
Member

@samuelgarcia Any last comments from your side before we merge?

@JuliaSprenger JuliaSprenger added this to the 0.10.0 milestone Jul 13, 2021
@JuliaSprenger JuliaSprenger merged commit cb45900 into NeuralEnsemble:master Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants