Properly anchor the collector name when locating the file #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ultiple connector with similar names work (eg. Http HttpCode)
Contributor
|
LGTM thanks for contributing @johvet ! Going to have the original author @nhatfield take a look as well. |
nhatfield
reviewed
Aug 13, 2020
| if [[ "${v}" == "COLLECTOR_"* ]]; then | ||
|
|
||
| FILE=`echo "${COLLECTORS}" | grep -i "$(echo "${v}" | sed 's%^COLLECTOR_%%;s%_.*%%' | tr 'A-Z' 'a-z')"` | ||
| FILE=`echo "${COLLECTORS}" | grep -i "^$(echo "${v}" | sed 's%^COLLECTOR_%%;s%_.*%%' | tr 'A-Z' 'a-z')$"` |
Contributor
There was a problem hiding this comment.
@johvet I agree this needs to be done. Would you mind if we do this native in grep? Just adding -w before or after the -i will do the trick. Appreciate your contribution
Thanks
Author
There was a problem hiding this comment.
Indeed, using -w is way more elegant. Wasn't thinking about that.
Contributor
|
@johvet: @rclagett rebased your PR onto dev and there's some commits from git checkout johvet/support-repeated-collector-names
git status // make sure the working directory is clean
git reset --hard dev // hard reset your branch to the dev branch
git cherry-pick 1aedda7 // cherry pick your commit onto dev
git push -f // force push to this PR |
Contributor
|
Hi @johvet are you okay to make the changes @nhatfield and @TheConnMan suggested? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue when trying to configure a collector with a repeated (portion) of the name, for example
Jolokia. This would matchCassandraJolokiaCollector.conf,JolokiaCollector.conf, andKafkaJolokiaCollector.confand theentrypoint.shfails. Same applies toHttp.