[Draft] Replace level_map and deprecate reference_point parameter#92
Draft
[Draft] Replace level_map and deprecate reference_point parameter#92
level_map and deprecate reference_point parameter#92Conversation
cfs-data
changed the title
level_map with built-in functionlevel_map with built-in function
cfs-data
changed the title
level_map with built-in functionlevel_map with built-in function and depecrate reference_point parameter
cfs-data
changed the title
level_map with built-in function and depecrate reference_point parameterlevel_map and depecrate reference_point parameter
cfs-data
changed the title
level_map and depecrate reference_point parameterlevel_map and deprecrate reference_point parameter
cfs-data
changed the title
level_map and deprecrate reference_point parameterlevel_map and deprecate reference_point parameter
Collaborator
|
@Raytesnel will PR impact us? |
Collaborator
ja |
Diff CoverageDiff: origin/main..HEAD, staged and unstaged changes
Summary
|
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intention for now is not to merge this PR, but to use it for testing. If no problems are encountered over time, this could be considered a replacement of the current implementation.
Changes:
level_map()is replaced by a built-in function fromsurfalizereference_pointhas no influence on end-to-end tests so this parameter has been removed in this branch.