Create build pipeline by Raytesnel · Pull Request #18 · NetherlandsForensicInstitute/scratch

Raytesnel · 2025-10-31T12:57:18Z

adds a build pipeline:
This makes a few changes to the pipelines

2 github actions are available:

PR's for the main branch:

tests code
tests the rest api contract is still the same
checks ruff

PR's for the release branch

builds the windows executable
tests contract on the build (verify the build)
if a (version) tag is given (ex: git tag v1.2) a release is made this release expects ./scratch/release_notes.txt description for the body.

small fixes in Just file.

if statement was in wrong order of the api-bg
just smoke-test now spins up its own api when not given a argument of a build (linux /windows build)
Removed the placeholder root api
add .coveragerc to ignore some parts of the code for the coverage check

snregales

I will continue my review once main conflicts are resolved

.github/workflows/release.yaml

.github/workflows/release.yml

pyproject.toml

src/main.py

snregales

remove catnet from dependencies it is no longer needed since you switch to curl

Justfile

.github/workflows/release.yml

.github/workflows/release.yaml

Justfile

snregales

close to done

.coveragerc

Justfile

This reverts commit 4ca7e4a.

This reverts commit 6d5d779.

This reverts commit bb4e871.

- remove linux build for testing purpose

… curl

…dure and manual build

github-actions · 2025-11-06T10:44:29Z

Diff Coverage

Diff: origin/main..HEAD, staged and unstaged changes

No lines with coverage information in this diff.

github-actions · 2025-11-06T10:44:30Z

Package	Line Rate	Branch Rate	Health
comparators	100%	100%	✔
pre_processors	100%	100%	✔
processors	100%	100%	✔
Summary	100% (15 / 15)	100% (0 / 0)	✔

Minimum allowed line rate is 50%

snregales-NFI

LGTM

Raytesnel self-assigned this Oct 31, 2025

Raytesnel force-pushed the create-build-pipeline branch from 07e9656 to 97de2fa Compare November 3, 2025 15:14

Raytesnel marked this pull request as ready for review November 4, 2025 14:38

snregales reviewed Nov 5, 2025

View reviewed changes

.github/workflows/release.yaml Outdated Show resolved Hide resolved

.github/workflows/release.yml Show resolved Hide resolved

pyproject.toml Show resolved Hide resolved

Raytesnel force-pushed the create-build-pipeline branch from 5f54c34 to 68d38ab Compare November 5, 2025 09:54

snregales reviewed Nov 5, 2025

View reviewed changes

src/main.py Show resolved Hide resolved

snregales reviewed Nov 5, 2025

View reviewed changes

snregales requested changes Nov 5, 2025

View reviewed changes

.coveragerc Outdated Show resolved Hide resolved

snregales reviewed Nov 5, 2025

View reviewed changes

Justfile Outdated Show resolved Hide resolved

snregales force-pushed the create-build-pipeline branch from abf982a to ebd806c Compare November 6, 2025 10:34

Raytesnel and others added 19 commits November 6, 2025 11:37

pyinstaller

73a73db

add just build

5ad57ee

update long form tags in just file

1029707

init_pipelines build

8254f30

flag markers instead of mark

fa95ae3

add uvicorn

2edb74d

some work not yet working order

e92d704

add stdenv for the libstdcxx missing lib

4c80a8f

bug of artifext main.py instead of correctly main.exe

63935a8

rewrite windows build

b0416d4

split actions in seperated steps for more clean debugging

d5f89c4

small typo log in build windows

385d443

Revert "small typo log in build windows"

17f07eb

This reverts commit 4ca7e4a.

Revert "split actions in seperated steps for more clean debugging"

dec1c73

This reverts commit 6d5d779.

Revert "rewrite windows build"

d9d8915

This reverts commit bb4e871.

- add logs for starting fastapi

fb14c0d

- remove linux build for testing purpose

correct way of giving arguments in just file fix

911a211

make artifact without testing it

734f050

typo 127.0.0.0 is wrong...

152d166

Raytesnel and others added 21 commits November 6, 2025 11:37

move build to release

d9fd9ce

move build to release

2922ab0

update smoke-test due to JustFile update

072a7de

update job name of release.yaml

cd36eb3

double startup dist/main.exe already coverd in just file.

34804ed

reuse test-contract from just

aea296d

reorder test-contract to just test

1fbfc83

a init template for release_notes.txt

e807b52

PR check in the jobs removed (forgotten after the copy)

09a7e6a

exclude main.py

185b9c0

removed placeholder endpoint.

7b390a5

add coverage config to the test report

dd2442d

removed the root placeholder from contract testing

6ca3912

remove duplication in api-bg

d16fa33

add check for kill process in smoketest depending on OS

95a9144

more optimized timeout line + use the host and port variables for the…

06038d4

… curl

removed unnecessary kill-api var

e7c54b0

add echo for contract testing

b969397

no netcat needed for windows. we use curl

c9867ec

split up the build in the release action to accommodate release proce…

b361061

…dure and manual build

Simplify smoke-test

7b36d11

snregales force-pushed the create-build-pipeline branch from ebd806c to 4cebb8a Compare November 6, 2025 10:40

migrate .coveragerc to pyproject.toml

7548365

snregales force-pushed the create-build-pipeline branch from 4cebb8a to 7548365 Compare November 6, 2025 10:42

snregales-NFI approved these changes Nov 6, 2025

View reviewed changes

snregales approved these changes Nov 6, 2025

View reviewed changes

Raytesnel merged commit 037a4e0 into main Nov 6, 2025
3 checks passed

Raytesnel deleted the create-build-pipeline branch November 6, 2025 10:56

Conversation

Raytesnel commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

snregales left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

snregales left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

snregales left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 6, 2025

Diff Coverage

Diff: origin/main..HEAD, staged and unstaged changes

Uh oh!

github-actions bot commented Nov 6, 2025

Uh oh!

snregales-NFI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Raytesnel commented Oct 31, 2025 •

edited

Loading