Skip to content

Change instance method to static method in filter.py#122

Merged
cfs-data merged 1 commit intomainfrom
change-method-to-static
Feb 6, 2026
Merged

Change instance method to static method in filter.py#122
cfs-data merged 1 commit intomainfrom
change-method-to-static

Conversation

@cfs-data
Copy link
Collaborator

@cfs-data cfs-data commented Feb 5, 2026

This makes it explicit that _generate_point_cloud is not an instance method

@cfs-data cfs-data requested a review from Raytesnel February 5, 2026 09:20
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Diff Coverage

Diff: origin/main..HEAD, staged and unstaged changes

  • packages/scratch-core/src/mutations/filter.py (100%)

Summary

  • Total: 1 line
  • Missing: 0 lines
  • Coverage: 100%

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Code Coverage

Package Line Rate Branch Rate Health
. 96% 88%
comparators 100% 100%
computations 100% 100%
container_models 99% 100%
conversion 97% 86%
conversion.export 100% 100%
conversion.filter 92% 83%
conversion.leveling 100% 100%
conversion.leveling.solver 100% 75%
conversion.plots 98% 85%
conversion.preprocess_impression 99% 91%
conversion.preprocess_striation 89% 58%
extractors 98% 75%
mutations 100% 100%
parsers 98% 80%
parsers.patches 89% 60%
preprocessors 95% 75%
processors 100% 100%
renders 98% 50%
utils 91% 75%
Summary 96% (2000 / 2073) 82% (207 / 254)

Minimum allowed line rate is 50%

@cfs-data cfs-data requested a review from snregales February 5, 2026 09:24
@cfs-data cfs-data merged commit 1aa4202 into main Feb 6, 2026
3 checks passed
@cfs-data cfs-data deleted the change-method-to-static branch February 6, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants