Skip to content

Remove cast from spatial.py#121

Merged
cfs-data merged 1 commit intomainfrom
remove-cast-from-spatial
Feb 6, 2026
Merged

Remove cast from spatial.py#121
cfs-data merged 1 commit intomainfrom
remove-cast-from-spatial

Conversation

@cfs-data
Copy link
Collaborator

@cfs-data cfs-data commented Feb 5, 2026

The use of cast() is unnecessary and is only "cosmetic". Better is to use np.asarray() directly with explicit dtype argument to perform the casting.

@cfs-data cfs-data requested a review from Raytesnel February 5, 2026 09:17
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Diff Coverage

Diff: origin/main..HEAD, staged and unstaged changes

  • packages/scratch-core/src/mutations/spatial.py (100%)

Summary

  • Total: 1 line
  • Missing: 0 lines
  • Coverage: 100%

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Code Coverage

Package Line Rate Branch Rate Health
. 96% 88%
comparators 100% 100%
computations 100% 100%
container_models 99% 100%
conversion 97% 86%
conversion.export 100% 100%
conversion.filter 92% 83%
conversion.leveling 100% 100%
conversion.leveling.solver 100% 75%
conversion.plots 98% 85%
conversion.preprocess_impression 99% 91%
conversion.preprocess_striation 89% 58%
extractors 98% 75%
mutations 100% 100%
parsers 98% 80%
parsers.patches 89% 60%
preprocessors 95% 75%
processors 100% 100%
renders 98% 50%
utils 91% 75%
Summary 96% (1998 / 2071) 82% (207 / 254)

Minimum allowed line rate is 50%

@cfs-data cfs-data requested a review from snregales February 5, 2026 09:24
@cfs-data cfs-data merged commit 690790b into main Feb 6, 2026
3 checks passed
@cfs-data cfs-data deleted the remove-cast-from-spatial branch February 6, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants