Draft
Conversation
Raytesnel
force-pushed
the
refactor-gaussian-filter
branch
from
8e495d5 to
b52847b
Compare
cfs-data
reviewed
Feb 5, 2026
| self.cutoff_pixels = cutoff_pixels | ||
| self.regression_order = regression_order | ||
|
|
||
| def calculate_polynomial_filter( |
Collaborator
There was a problem hiding this comment.
Maybe you could actually remove these local functions and use the implementation in conversion instead, since you need to change the code anyway later
cfs-data
reviewed
Feb 5, 2026
| if y + x <= order | ||
| ] | ||
|
|
||
| def apply_on_image(self, scan_image: ScanImage) -> ScanImage: |
Collaborator
There was a problem hiding this comment.
I think only implementing this function should be sufficient for this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
for the
get_cropped_imagethe next function calls are needed.clip_factorsresample_scan_imageapply_mask_imagecrop_to_masklevel_mapapply_gaussian_regression_filterThis PR is converting
apply_gaussian_regression_filterChanges:
TODO: