BSZ-213: Add functionality to serialize/deserialize LR models for given mark/score types#12
Merged
BSZ-213: Add functionality to serialize/deserialize LR models for given mark/score types#12
Conversation
To be able to re-use the data in other tests, the generated fixture data is provided as pytest fixture
JoBraNFI
force-pushed
the
serialize-models
branch
from
15b18f7 to
c777755
Compare
JoBraNFI
changed the title
Contributor
PimMeulensteen
left a comment
PimMeulensteen
left a comment
There was a problem hiding this comment.
Ziet er wat mij betreft goed uit!
Ik maak me alleen zorgen over pickle in combinatie met het upgraden van lir. Voor zover ik weet moet je bij het inladen van pickle exact hetzelfde class-object gebruiken. Dit zou betekenen dat je modellen uit een bepaalde lir versie alleen in die lir versie kan openen.
Ik weet niet of we nog andere opties hebben? Is het mogelijk met de to_dict en from_dict functionaliteit in combinatie met JSON? Als we geen goede andere optie hebben, lijkt me pickle sowieso de beste optie.
JoBraNFI
force-pushed
the
serialize-models
branch
from
c777755 to
d5d0fab
Compare
PimMeulensteen
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other methods are described: