Small improvements#65
Draft
Repsay wants to merge 2 commits intoNetherlandsForensicInstitute:masterfrom
Draft
Conversation
First part of NetherlandsForensicInstitute#60 to split in parts. First just adding type hinting and making PEP8 compliant. Small improvements and fixing small bugs. Removing changing global variables.
Some small improvements for optimizations. Added fallback encodings. de-nest lot of code in clean_up. split between bytes processing and string processing to reduce unnecessary re-encoding/decoding. Instead of stop use continue to speed up processing. Instead of changing locale use it directly in opening the file. Part of NetherlandsForensicInstitute#60
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some small improvements for optimizations. Added fallback encodings. de-nest lot of code in clean_up. split between bytes processing and string processing to reduce unnecessary re-encoding/decoding. Instead of stop use continue to speed up processing. Instead of changing locale use it directly in opening the file. Part of #60. Builds on #64