Merged
Conversation
akaIDIOT
force-pushed
the
feature/benchmarks
branch
3 times, most recently
from
3f09e40 to
da10b18
Compare
akaIDIOT
force-pushed
the
feature/benchmarks
branch
from
da10b18 to
41cba06
Compare
akaIDIOT
commented
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended to be able to see performance impact of changes in the future.
This PR needs to be about benchmarks that measure something that is worth measuring.
Another PR would be able to add a step to the actions, checking out the main branch and running the benchmarks again, allowing another job to collect all the results and create a comparison matrix between the main branch and the pull request, per benchmark and python version if needed.