Skip to content

Allow path template loaders to be ... Paths#134

Open
akaIDIOT wants to merge 4 commits intomainfrom
feature/allow-path-template-loader
Open

Allow path template loaders to be ... Paths#134
akaIDIOT wants to merge 4 commits intomainfrom
feature/allow-path-template-loader

Conversation

@akaIDIOT
Copy link
Member

After looking at the type conversions in #132, it looked silly that the loaders in the load_order were required to be strings. Paths should be equally valid.

confidence/io.py Outdated
warnings.warn(
'using "{extension}" in string template loaders has been deprecated, use "{suffix}" instead',
category=DeprecationWarning,
stacklevel=4, # warn about user code calling load_name rather than _resolve_source
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stack level for this was checked manually, warning now points to the line calling load_name(...).

@akaIDIOT akaIDIOT force-pushed the feature/allow-path-template-loader branch from 67e07b7 to 27fc0f8 Compare January 21, 2026 15:16
@github-actions
Copy link

github-actions bot commented Jan 21, 2026

Comparing median (lower is better) metric of benchmarks between this PR's target (8055282) and the HEAD of this PR (59a0374):

3.10 3.11 3.12 3.13 3.14 PyPy 3.10 PyPy 3.11
test_benchmark_get +1% -1% +2% -2% -0% +3% +1%
test_benchmark_get_dotted +1% +4% +0% -1% +1% +1% -2%
test_benchmark_getattr +3% -1% +3% -2% +1% +2% +3%
test_benchmark_getitem +1% -1% +2% -2% +2% +1% +2%
test_benchmark_getitem_dotted -0% -0% +0% -0% +1% +4% +0%
test_benchmark_init_full_overlap -1% -0% -0% -1% +1% -1% +1%
test_benchmark_init_no_overlap +0% +1% +0% -0% +1% -1% +1%
test_benchmark_init_partial_overlap -0% +0% +0% -0% +1% -1% +1%
test_benchmark_reference_chain -1% -0% +1% +0% +1% -2% -2%
test_benchmark_splat_args -1% -0% +0% -1% +2% -2% +0%
test_benchmark_spread_kwargs -2% +1% +2% -2% +1% -2% +0%

(This comment will be updated on subsequent pushes)

@akaIDIOT akaIDIOT requested a review from ranieri January 21, 2026 16:32
@akaIDIOT akaIDIOT marked this pull request as ready for review January 22, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant