IRC rooms in config should start with # #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It took me a while to realize this. If they don't it can have undesired side effects (the whole delay_task and loop_task mechanism will stop working and your log size will increase dramatically).
Contributor
|
this might be better reflected in the docs, as this only applies to IRC, whereas jabber/hipchat rooms don't require this. I'll give it a once over tomorrow. |
Author
|
Certainly. The rationale of this PR was to fix the example config so that when anyone tries to just quickly edit it doesn't have to realize that the channel should start with #. However, reflecting this in docs does certainly make sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me a while to realize this.
If they don't it can have undesired side effects (the whole delay_task
and loop_task mechanism will stop working and your log size will
increase dramatically).