This repository was archived by the owner on Dec 19, 2025. It is now read-only.
Support creation of cross hostedzone Route53 alias records. #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhances the api to allow creation of alias records where the target could be in a different hosted zone and also supports setting the target health check flag on the alias record. The different hosted zone is quite common if we are creating an alias to an Amazon Load Balancer. Also, without the health check flag being set, the AWS api will throw an exception when creating an alias to an ELB. Finally, when creating an alias record, the api was failing because an empty ResourceRecord was being passed to the create request.
|
asgard-pull-requests #424 FAILURE |
added 2 commits
May 21, 2014 20:50
The hosted zone id of the alias target is different from that of the hosted zone from which the record is being removed. Using the hosted zone id of the zone from which the record is being deleted is not correct.
|
asgard-pull-requests #425 SUCCESS |
Apparently there is a limit of 400 ELBs per request, and we need to start using the "optional" marker to get the rest.
Similar to a properties file.
…to ones that have a purpose.
This allows Asgard for certain AWS accounts to use properties file formatted user data for all windows AMI deployments, without changing the behavior of Asgard managing other AWS accounts.
…lication from a single source account. The old code assumed that there could only be a single target account for image replication.
|
asgard-pull-requests #452 SUCCESS |
because last() throws an exception for an empty Collection
In order to support automatically taking any block device mapping of an AMI into an ASG they can be taken from the image itself. Any default EBS volumes on the AMI will be mounted as usual. This solves the issue we've been having with asgard not mounting the ephemeral disks in the AMI
Gives presedence for those in the configuration
…us ASG. We do not want to disable the whole ASG.
|
asgard-pull-requests #459 SUCCESS |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances the api to allow creation of alias records where the target
could be in a different hosted zone and also supports setting the target
health check flag on the alias record.
The different hosted zone is quite common if we are creating an alias to
an Amazon Load Balancer.
Also, without the health check flag being set, the AWS api will throw an
exception when creating an alias to an ELB.
Finally, when creating an alias record, the api was failing because an
empty ResourceRecord was being passed to the create request.