Remove final flush of instrumentation data from the AccessMonitorUtil #759
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nowucca
approved these changes
Aug 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instrumentation flushing feature in the AccessMonitorUtil is meant to be as non-invasive as possible. However, we currently have calls outside the dedicated threadpool when shutting down the AccessMonitorUtil. The intention here was to make sure we aren't missing any instrumentation data that accrued at the end, but this also puts a call on the main thread (which could have issues such as blocking JVM shutdown on hangs).
So, we choose to be non-invasive over completeness of information. To be clear, it's quite unlikely that we will actually be losing data in any meaningful way (since property usage is generally either at startup, or just throughout the uptime of an application, meaning that any instrumentation dropped in the last window is very likely to have been seen already).