support unit test with picotest. This unit test runs when the libtlp is compiled. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sora
changed the title
Collaborator
|
Please do not put source files on the top of repository. Please make a directory for unit tests, and put unit test codes into the directory. Unfortunately, |
upa
reviewed
Jul 28, 2020
unit_test.c
Outdated
| result_length = tlp_calculate_length(0x0, 0); | ||
| ok(result_length == 0); | ||
|
|
||
| result_length = tlp_calculate_length(0x1, 0); |
Collaborator
There was a problem hiding this comment.
This test fails. the correct behavior is 0?
unit_test.c
Outdated
| ok(result_length == 1023); | ||
|
|
||
| result_length = tlp_calculate_length(0x0, 4093); | ||
| ok(result_length == 0); |
Collaborator
There was a problem hiding this comment.
These four tests also fail. result_length must be 1024.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.