Skip to content

fix: surface invoice generation errors #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NessieCanCode wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: surface invoice generation errors #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/slurmcostmanager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,7 +923,10 @@ function Details({
}
const output = await window.cockpit.spawn(
['python3', `${PLUGIN_BASE}/invoice.py`],
{ input: JSON.stringify(invoiceData), err: 'out' }
// Capture stderr as the error message so problems like missing
// Python dependencies surface to the user instead of a generic
// "python3 exited with code 1" message.
{ input: JSON.stringify(invoiceData), err: 'message' }
);
const trimmed = output.trim();
if (!trimmed) {
Expand Down
Loading