feat: add remove button to floating attachment preview#580
feat: add remove button to floating attachment preview#580Aeledfyr wants to merge 1 commit intoNerimity:mainfrom
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |

This adds a button to the floating attachment preview to remove the attachment, to make it consistent with replies. The existing add attachment button turns into a close/remove button after being clicked, but that isn't the first place someone would look when trying to remove the attachment.
The button doesn't end up in a great place on mobile; if you can think of a better place for it or an alternate design, that would be helpful. (The general expectation is that close buttons are in the top right/top left corner, depending on OS; modal close buttons are usually in the bottom right or bottom left, so we might be able to style it that way?)
Screenshots
Did you test your code?
Tested on Firefox on desktop and Chrome on Android.
Checklist
Text/content changes support internationalization (i18n)(N/A)Any new user-facing strings are properly localized(N/A)