Skip to content

feat: add remove button to floating attachment preview#580

Draft
Aeledfyr wants to merge 1 commit intoNerimity:mainfrom
Aeledfyr:remove-attachment-button
Draft

feat: add remove button to floating attachment preview#580
Aeledfyr wants to merge 1 commit intoNerimity:mainfrom
Aeledfyr:remove-attachment-button

Conversation

@Aeledfyr
Copy link
Contributor

This adds a button to the floating attachment preview to remove the attachment, to make it consistent with replies. The existing add attachment button turns into a close/remove button after being clicked, but that isn't the first place someone would look when trying to remove the attachment.

The button doesn't end up in a great place on mobile; if you can think of a better place for it or an alternate design, that would be helpful. (The general expectation is that close buttons are in the top right/top left corner, depending on OS; modal close buttons are usually in the bottom right or bottom left, so we might be able to style it that way?)

Screenshots

image image

Did you test your code?

Tested on Firefox on desktop and Chrome on Android.

Checklist

  • Changes are clear, concise, and easy to review
  • Code has been tested and works as intended
  • Text/content changes support internationalization (i18n) (N/A)
  • Any new user-facing strings are properly localized (N/A)

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 26, 2026

Warning

Rate limit exceeded

@Aeledfyr has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 52 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between d9b4a56 and bdab2e5.

📒 Files selected for processing (2)
  • src/components/message-pane/MessagePane.tsx
  • src/components/message-pane/styles.module.scss
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@SupertigerDev
Copy link
Member

SupertigerDev commented Feb 26, 2026

but this cross icon already closes the attachment
image

@Aeledfyr Aeledfyr marked this pull request as draft February 28, 2026 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants