Add native Android module for inline custom emoji images in notifications#2
Open
mathiiiiiis wants to merge 5 commits intoNerimity:webviewfrom
Open
Add native Android module for inline custom emoji images in notifications#2mathiiiiiis wants to merge 5 commits intoNerimity:webviewfrom
mathiiiiiis wants to merge 5 commits intoNerimity:webviewfrom
Conversation
…ions Replaces notifee with a custom NotificationCompat.Builder that renders emoji images inline using RemoteViews, and adds server/DM context via subText
Use correct file extensions for emoji types (gif for animated, webp for static/webp-animated) and clear message history when notifications are swiped away via a BroadcastReceiver
- Buffer bitmap bytes before decoding to fix unreliable emoji image loading on Samsung (BitmapFactory.decodeStream fails on non-marking network streams) - Replace 🖼️ fallback with :name: format for unloaded custom emojis - Bold sender username in server and DM notification message rows
Pass channelId/serverId/userId as intent extras, capture them in MainActivity onCreate/onNewIntent, and retrieve from JS via a new getPendingNotificationClick() native method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces notifee with a custom NotificationCompat.Builder that renders emoji images inline using RemoteViews, and adds server/DM context via subText
For this to function as intended, the following PR also needs to be merged:
Nerimity/nerimity-server#37