Open
Conversation
NearlyUnique
reviewed
Jun 4, 2019
| } else { | ||
| // Print the error, cast err to awserr.Error to get the Code and | ||
| // Message from an error. | ||
| journal("Unable to resolve account alias", err.Error()) |
Owner
There was a problem hiding this comment.
why don't you keep the error?
Author
There was a problem hiding this comment.
It was my first try to use go and my IDE said that there are to much Parameters used in method journal, so I deleted it ;-)
NearlyUnique
reviewed
Jun 4, 2019
| "net/http/httptest" | ||
| "testing" | ||
|
|
||
| "github.com/NearlyUnique/awsSts/cmd" |
Owner
There was a problem hiding this comment.
I thought it was more common to use std pks at the top then others?
Author
There was a problem hiding this comment.
It was my first try to use go ;-)
NearlyUnique
reviewed
Jun 4, 2019
| if err == nil { | ||
| f.Close() | ||
| } else { | ||
| fatalExitf(err, "Failed to create required file", filePath) |
Owner
There was a problem hiding this comment.
why ignore the extra filePath info?
Author
There was a problem hiding this comment.
It was my first try to use go and my IDE said that there are to much Parameters used in method fatalExitf, so I deleted it ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support of setting the duration of validity of the aws credentials as parameter