fix(cli): mask private key and API key inputs in shade auth#22
Open
mattlockyer wants to merge 1 commit intomainfrom
Open
fix(cli): mask private key and API key inputs in shade auth#22mattlockyer wants to merge 1 commit intomainfrom
mattlockyer wants to merge 1 commit intomainfrom
Conversation
Use @inquirer/password instead of @inquirer/input for the NEAR private key and Phala API key prompts so sensitive values are not visible in the terminal. Closes #21 Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shade auth setfrom@inquirer/inputto@inquirer/passwordwithmask: true, so sensitive values are displayed as*characters instead of plaintext@inquirer/passwordas a new dependencyCloses #21
Test plan
shade auth setand selectnear— verify the private key input is maskedshade auth setand selectphala— verify the API key input is maskedshade auth setand selectall— verify both private key and API key inputs are maskedMade with Cursor