Skip to content

fix proxy bug #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huyangkkk wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix proxy bug #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdb0792
fix bug commit
huyangkkk Oct 28, 2024
0ec90e5
Update HttpClient.php
huyangkkk Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/HttpClient/HttpClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ public function getRequestPromise(Request $request): PromiseInterface
}

return $this->client
->sendAsync($request->getPsrRequest(), $request->getOptions())
->sendAsync($request->getPsrRequest(), $options)
->then(function (ResponseInterface $response) use ($request, $cacheKey, $options) {
$parseResult = $request->getParseHandler()($request->getPsrRequest(), $response, $options);
if ($cacheKey !== null && $parseResult !== null) {
Expand Down
4 changes: 2 additions & 2 deletions src/Model/AppInfo.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,9 @@ public function getDeveloperName(): ?string
/**
* Returns a summary of the application.
*
* @return string summary of the application
* @return string|null summary of the application
*/
public function getSummary(): string
public function getSummary(): ?string
{
return $this->summary;
}
Expand Down
4 changes: 2 additions & 2 deletions src/Scraper/AppInfoScraper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public function __invoke(RequestInterface $request, ResponseInterface $response,
$country = $query[GPlayApps::REQ_PARAM_COUNTRY] ?? GPlayApps::DEFAULT_COUNTRY;

$name = $appInfo[0][0];
$description = ScraperUtil::html2text($appInfo[72][0][1]);
$description = ScraperUtil::html2text($appInfo[12][0][0][1] ?? $appInfo[72][0][1]);
$developer = $this->extractDeveloper($appInfo);

$category = $this->extractCategory($appInfo[79][0][0] ?? []);
Expand Down Expand Up @@ -110,7 +110,7 @@ public function __invoke(RequestInterface $request, ResponseInterface $response,
$cover = $this->extractCover($appInfo);
$screenshots = $this->extractScreenshots($appInfo);
$video = $this->extractVideo($appInfo);
$contentRating = $appInfo[111][1] ?? '';
$contentRating = $appInfo[9][0] ?? '';
$released = $this->convertDate($appInfo[10][1][0] ?? null);
$updated = $this->convertDate($appInfo[145][0][1][0] ?? null);
$recentChanges = $this->extractRecentChanges($appInfo);
Expand Down