Add MP3 output support via lame encoding#1
Open
mattlockyer wants to merge 1 commit intoNavaneethsen:mainfrom
Open
Add MP3 output support via lame encoding#1mattlockyer wants to merge 1 commit intoNavaneethsen:mainfrom
mattlockyer wants to merge 1 commit intoNavaneethsen:mainfrom
Conversation
Generate MP3 files by default instead of WAV. Synthesizes to WAV first, then converts using lame. Includes convenience narrate.sh script.
mattlockyer
force-pushed
the
feature/mp3-support
branch
from
9aca099 to
ba4f72c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lamelameif not foundnarrate.shscript for quick usageTest plan
.mp3output and verify MP3 file is produced.wavoutput and verify WAV still workslameinstalled and verify the install prompt appears