Replace the NSNotificationCenter mechanism in the quote creation flow #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing segues and closures instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reading through the code, it caught my eye that the quote creation flow uses
NSNotificationCenterto notify the list of quotes that a new quote was created. I not a very big fan ofNSNotificationCenter, and some of my reasons are described here.I made a small fix replacing the
NSNotificationCentermechanism by a new one using a segue identifier and a quote creation handler (implemented as a closure in theCreateQuoteTableViewController). I think we can discuss the validity (and code quality) of the fix and if it fits the purpose of the example.Thanks!