matrix.h had unknown function nrows() and ncols() that should not have compiled#190
matrix.h had unknown function nrows() and ncols() that should not have compiled#190
Conversation
|
@sjanzou Thanks for fixing. I noticed this when trying to build on Mac yesterday. The latest version of XCode is 26. Should we be using Version 16.4 to build SAM? |
@cpaulgilman , my Mac has not finished updating to XCode 26, let me test and I will let you know. |
brtietz
left a comment
There was a problem hiding this comment.
Approving for these changes. Happy to re-review for Xcode/Clang version upgrades in the future.
@brtietz @cpaulgilman building and running with wxWidgets 3.2.8.1 on MacOS 26.0 with XCode 26.0.1 with Clang 17.1.1.17000319 with modification to configure and configure.in to remove deprecated -framework AGL per
|

matrix.h would not compile on XCode 16.4 and should not have built on other platforms. wxMatrix::ResizePreserve had undefined methods nrows() and ncols() used. Luckily the ResizePreserve function was not used elsewhere in the code base.