Open
Conversation
…v9.14 for Ubuntu runner
sjanzou
requested review from
brtietz,
cpaulgilman,
janinefreeman,
qualand and
tyneises
brtietz
requested changes
Feb 11, 2026
Collaborator
brtietz
left a comment
brtietz
left a comment
There was a problem hiding this comment.
Please ensure that new files get the appropriate copyright notices. Are lib_ortools.h/cpp and lob_ptes_chp_dispatch NLR code or third party?
Additionally, please update the README to reflect what libraries we're using now. (ortools, did anything get removed?)
| mkdir ${GTEST}/build | ||
| cd ${GTEST}/build | ||
| cmake -DCMAKE_CXX_FLAGS=-std=c++11 .. | ||
| cmake -DCMAKE_CXX_FLAGS=-std=c++17 .. |
Collaborator
There was a problem hiding this comment.
Flagging another c++17 - Is this intentional for gtest?
if(MSVC) set(CMAKE_CXX_STANDARD 20) else() set(CMAKE_CXX_STANDARD 17) endif()
brtietz
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/NatLabRockies/SAM-private/pull/140