Skip to content

Conversation

Copy link

Copilot AI commented Feb 4, 2026

Description

The PVDAQ example notebooks used a temperature coefficient of -0.005 1/K, which is too large for modern silicon modules and not representative of typical datasheet values. Updated to -0.0034 1/K, a more appropriate value for modern silicon cells.

Changes

  • Updated gamma_pdc parameter from -0.005 to -0.0034 in three notebooks:
    • docs/degradation_and_soiling_example.ipynb
    • docs/TrendAnalysis_example.ipynb
    • docs/TrendAnalysis_example_NSRDB.ipynb
  • Added inline comment: # Temperature coefficient for modern silicon PV modules (1/K)
  • Updated docs/sphinx/source/changelog/pending.rst with a new "Documentation" section documenting the temperature coefficient change

This provides a more appropriate default for users adapting these notebooks to their own systems.

Checklist

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog
Original prompt

This section details on the original issue you should resolve

<issue_title>Notebook temperature coefficients could be improved</issue_title>
<issue_description>The PVDAQ4 notebooks assume a temperature coefficient of -0.005 1/K. This might be undesirable in two ways:

  • -0.005 1/K is rather large in magnitude; a smaller value would probably be more generally suitable if people are leaving it at the default when they swap in their own time series data
  • -0.005 1/K doesn't match the datasheet value for this system's modules, so it's not correct for the particular system under test either

After offline discussion it was decided to add an explanatory comment in the notebooks for now, and in the longer term (RdTools 3.0) update the value to something more suitable.

For reference, it seems that the -0.005 1/K value has been carted around ever since 2017 when the notebook was first added (see #17 and specifically 161dec5).

Thanks @adriesse for pointing this out!</issue_description>

<agent_instructions>Modern silicon solar cells have a temperature coefficient of around -0.0034. Let's update the notebook accordingly. </agent_instructions>

Comments on the Issue (you are @copilot in this section)

@mdeceglie Oops, we missed this one in the 3.0 release!

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: martin-springer <97482055+martin-springer@users.noreply.github.com>
Copilot AI changed the title [WIP] Update notebook temperature coefficient with explanatory comment Update temperature coefficient in PVDAQ notebooks to -0.0034 Feb 4, 2026
Copilot AI requested a review from martin-springer February 4, 2026 19:14
@martin-springer
Copy link
Collaborator

@copilot - Update the pending.rst changelog.

Co-authored-by: martin-springer <97482055+martin-springer@users.noreply.github.com>
Copy link
Author

Copilot AI commented Feb 4, 2026

@copilot - Update the pending.rst changelog.

Updated the pending.rst changelog in commit aa338b6. Added a "Documentation" section with details about the temperature coefficient update.

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.28%. Comparing base (e107469) to head (def3417).

Additional details and impacted files
@@                          Coverage Diff                           @@
##           fix-numpy-and-pandas-compatibility     #478      +/-   ##
======================================================================
+ Coverage                               96.10%   96.28%   +0.17%     
======================================================================
  Files                                      12       12              
  Lines                                    2287     2287              
======================================================================
+ Hits                                     2198     2202       +4     
+ Misses                                     89       85       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@martin-springer martin-springer marked this pull request as ready for review February 4, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants