Skip to content

Conversation

@misi9170
Copy link
Collaborator

@misi9170 misi9170 commented Dec 25, 2025

This PR makes a handful of updates to docstrings throughout FLORIS to respond to minor issues that have been raised.

@misi9170 misi9170 changed the title Improve docstrings and warnings Improve various docstrings Dec 25, 2025
@rafmudaf
Copy link
Collaborator

rafmudaf commented Jan 5, 2026

Hey @misi9170 I have a few things to add along these lines, if you don't mind waiting a few days for me to submit a PR to your branch

@misi9170
Copy link
Collaborator Author

misi9170 commented Jan 5, 2026

@rafmudaf please do, no rush. Fine also for you to simply commit and push into my branch if you'd like.

@misi9170 misi9170 marked this pull request as draft January 7, 2026 16:17
@misi9170
Copy link
Collaborator Author

misi9170 commented Jan 7, 2026

Converting to draft while I'm still planning to address a couple of things:

@misi9170 misi9170 mentioned this pull request Jan 7, 2026
@misi9170 misi9170 marked this pull request as ready for review January 15, 2026 20:47
@misi9170
Copy link
Collaborator Author

Given the imminent change of the github organization #1177 , I intend to merge this PR soon and include it in an upcoming patch release for FLORIS v4.6. @rafmudaf and I spoke and decided to hold off on including his docs changes in this PR. Ready for review.

@misi9170 misi9170 requested a review from paulf81 January 15, 2026 20:49
@misi9170
Copy link
Collaborator Author

@paulf81 , I've added you as a reviewer; hopefully, that's ok. Can you take a closer look at the documentation I've added for Serial Refine and then a quick pass over the rest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants