-
Notifications
You must be signed in to change notification settings - Fork 182
Add turbine_average_velocities property to UncertainFlorisModel
#1135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add turbine_average_velocities property to UncertainFlorisModel
#1135
Conversation
|
The failing tests seem unrelated to this PR but I could be mistaken |
|
Thanks @paulf81 , this looks good to me. I've added a few things:
As we discussed, I've also:
I think this looks good. However, there are still a lot of methods on |
turbine_average_velocities property to UncertainFlorisModel
|
@paulf81 , any objections/comments on the changes I made? If not, I think I can merge. |
Yes, these look great, thank you! |
Add turbine average velocity property to UncertainFLorisModel
This PR adds a property to allow getting the per-turbine average velocities from an UncertainFlorisModel. This property exists for FlorisModel. To provide this capability in UncertainFLorisModel requires mirroring the logic in get_turbine_powers to go from the expanded internal FlorisModel (which includes all the unique conditions after expanding across neighboring wind directions according to the wd_std) back to the un_expanded originally requested wind directions.
Several tests are included to check the functino works as expected
Impacted areas of the software
uncertain_floris_model.py
Test results, if applicable
New tests pass