Removed some shape_by_conn calls due to OM issues#632
Merged
johnjasa merged 5 commits intoNatLabRockies:developfrom Mar 27, 2026
Merged
Removed some shape_by_conn calls due to OM issues#632johnjasa merged 5 commits intoNatLabRockies:developfrom
johnjasa merged 5 commits intoNatLabRockies:developfrom
Conversation
jmartin4u
approved these changes
Mar 27, 2026
Collaborator
jmartin4u
left a comment
jmartin4u
left a comment
There was a problem hiding this comment.
Verified that this fixes splitter operation with openmdao==3.43.0 on my Win11 machine. Added a fix for the test_pipe_with_hydrogen that was failing, should be passing now
Collaborator
Author
|
Awesome, thanks for verifying and for the test fix, @jmartin4u! I appreciate it. |
…Integrate into remove_shape_by_conn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove shape by conn calls
As noted by @jmartin4u in #616 the splitter is failing to correctly split in certain edge cases; he had a fix and shared it.
Based on some quick checking, there were many behind-the-scenes changes in the connection setup between OM v3.42 and v3.43.
Without digging too much, there's enough changed in OM that I don't think it's worth figuring out why this isn't working; just to use this fix.
Section 1: Type of Contribution