Move xdsm call in H2IntegrateModel to its own method#629
Merged
johnjasa merged 12 commits intoNatLabRockies:developfrom Mar 27, 2026
Merged
Move xdsm call in H2IntegrateModel to its own method#629johnjasa merged 12 commits intoNatLabRockies:developfrom
johnjasa merged 12 commits intoNatLabRockies:developfrom
Conversation
…desired instead of having it be automatic
johnjasa
requested changes
Mar 26, 2026
Collaborator
johnjasa
left a comment
There was a problem hiding this comment.
Thanks for this, Jared! I think it's good to have it be optional.
Could you please:
- add to the changelog
- add to the docs where appropriate about this
create_xdsmfunctionality, maybe inhow_to_set_up_an_analysis.md?
…t it is an optional call
johnjasa
approved these changes
Mar 27, 2026
Collaborator
johnjasa
left a comment
There was a problem hiding this comment.
Thanks for these updates, Jared! I really like the amount of detail you added in the docs, as well as the useful figures and links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move xdsm call in H2IntegrateModel to its own method
Having the xdsm call happen in tech interconnect leads to a lot of extra processing and print statements that are not necessary when calling H2I multiple times for similar cases. I moved the xdsm call to a method so it can still be called on the h2i model instance, but only when desired.
I also added some documentation on visualizing an H2I model with XDSM and N2 diagrams.
Section 1: Type of Contribution
Section 2: Draft PR Checklist
TODO:
Type of Reviewer Feedback Requested (on Draft PR)
Structural feedback:
Implementation feedback:
Other feedback:
Section 3: General PR Checklist
docs/files are up-to-date, or added when necessaryCHANGELOG.md"A complete thought. [PR XYZ]((https://github.com/NatLabRockies/H2Integrate/pull/XYZ)", where
XYZshould be replaced with the actual number.Section 3: Related Issues
Section 4: Impacted Areas of the Software
Section 4.1: New Files
path/to/file.extensionmethod1: What and why something was changed in one sentence or less.Section 4.2: Modified Files
path/to/file.extensionmethod1: What and why something was changed in one sentence or less.Section 5: Additional Supporting Information
Section 6: Test Results, if applicable
Section 7 (Optional): New Model Checklist
docs/developer_guide/coding_guidelines.mdattrsclass to define theConfigto load in attributes for the modelBaseConfigorCostModelBaseConfiginitialize()method,setup()method,compute()methodCostModelBaseClasssupported_models.pycreate_financial_modelinh2integrate_model.pytest_all_examples.pydocs/user_guide/model_overview.mddocs/section<model_name>.mdis added to the_toc.yml