Open
Conversation
…hancement/windows-ci
…/H2Integrate into enhancement/windows-ci
…/H2Integrate into enhancement/windows-ci
…dependency-determined skipped tests
…tial windows resolution
This reverts commit 679a38d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unpin
coin-or-cbcto enable simplified Windows installationsThis PR adopts
coin-or-cbcversion 2.10.12 or greater to coincide with the conda-forge packaging. All CI and installation instructions have also been updated. In addition, the nonfunctional Code-Coverage integration has been swapped with Coveralls.Several updates needed to be made for consistent results on Windows and all other OS:
temp_dirfixture's scope was downgraded to only functions because Windows was unable to handle tests accessing the same file.temp_copy_of_examplefixture was moved to the top-levelconftest.py, and is now imported in all lower-levelcontest.pyfiles.temp_copy_of_example_module_scopewas created, but not universally imported to allow for the tests inh2integrate/core/test/test_recorder.pyto run through the process of creating SQL report files using the same base name across multiple process.Section 1: Type of Contribution
Section 2: Draft PR Checklist
TODO:
Type of Reviewer Feedback Requested (on Draft PR)
Structural feedback:
Implementation feedback:
Other feedback:
Section 3: General PR Checklist
docs/files are up-to-date, or added when necessaryCHANGELOG.mdhas been updated to describe the changes made in this PRSection 3: Related Issues
Closes #25
Section 4: Impacted Areas of the Software
Section 4.1: New Files
N/A
Section 4.2: Modified Files
**/test/conftest.py: All conftest files now import the now top-leveltemp_copy_of_examplefor isolated access to examples data..github/workflows/ci.yml:README.md&docs/getting_started/install.md: updates Windows installations instructionsenvironment.yml: Adds the latestcoin-or-cbcdependency universallyexamples/test/test_all_examples.pyexamples/test/test_all_examples.py: moved totest/conftest.pytest_28_iron_map_example: skipped whengisoptional dependencies are not installed.h2integrate/postprocess/test/test_mapping_tools.py: skips all tests whengisoptional dependencies are not installed.test/conftest.py:temp_dir: downgraded to a function-scoped fixture to allow tests to pass on Windowstemp_dir_module: copy oftemp_dir, but without teardown between functions in a moduletemp_copy_of_example_module_scope: copy oftemp_copy_of_example, but without teardown between functions in a moduleh2integrate/core/test/test_recorder.py: Uses the module scoped example copy fixture to streamline the creation of multiple identically named files across multiple copies. All folder usage and checks have been updated to match with additional streamlining.h2integrate/postprocess/test/test_sql_timeseries_to_csv.py: Uses thetemp_copy_of_examplefixture to potentially isolate the access to the .sql files for consistent results in Windows.h2integrate/converters/co2/marine/test/conftest.py:driver_config: converted to function scope to avoid compatibility issues withtemp_dir's scope.Section 5: Additional Supporting Information
N/A
Section 6: Test Results, if applicable
N/A